replace Checkstyle with com.coveo:fmt-maven-plugin for code formatting checks#135
Merged
Conversation
which makes the 'release' profile redundant, and the copyright-header.txt file address a conflict found by maven-enforcer-plugin's requireUpperBoundDeps rule regarding org.codehaus.plexus:plexus-component-annotations
mattnworb
force-pushed
the
mattbrown/rm-checkstyle
branch
from
3876438 to
8836314
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
============================================
+ Coverage 84.79% 85.10% +0.31%
+ Complexity 228 227 -1
============================================
Files 23 23
Lines 822 846 +24
Branches 100 100
============================================
+ Hits 697 720 +23
- Misses 89 90 +1
Partials 36 36
Continue to review full report at Codecov.
|
spkrka
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #125 (comment)
a lot of projects inside Spotify use the fmt-maven-plugin nowadays, since it is easy to resolve any style/formatting issues by having the Maven build automatically reformat code for you.
Also added
foss-rootas a parent to simplify some things.